fix: safely integrate design-audit remediations by BigSimmo · Pull Request #859 · BigSimmo/Database

BigSimmo · 2026-07-18T13:21:26Z

Summary

Safely replayed the requested 51278a70d design-audit remediations onto fresh origin/main in an isolated worktree.
Resolved overlapping conflicts with current-main schema and runtime behavior preserved.
Corrected the resulting sitemap-generator duplication and removed stale duplicate test expectations.

Verification

git diff --check
npm run sitemap:check
Verification not run: npm run test was blocked by the repository-wide heavyweight lock held by a separate worktree Playwright run; this PR's Unit coverage check is required before merge.
UI verification not run: npm run verify:ui was not run locally because the shared heavyweight slot was occupied; this PR's Production UI check is required before merge.

Risk and rollout

Risk: low; the effective change preserves current runtime behavior and corrects merge-introduced generator/test configuration defects.
Rollback: revert this PR's three commits to return exactly to the pre-integration main state.
Provider or production effects: No provider, Supabase, OpenAI, deployment, or production mutation was performed.

Summary by CodeRabbit

Bug Fixes
- Improved handling and coverage for public redirects, including clearer separation from API routes.
- Preserved sitemap validation and Clinical Guide interface behavior during integration.
Documentation
- Added a review record documenting historical integration work, conflict resolutions, and validation results.
Tests
- Updated redirect test descriptions to accurately reflect expected sitemap and API-route behavior.

(cherry picked from commit 51278a7)

coderabbitai · 2026-07-18T13:21:32Z

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 4ab4ab07-35f2-4fa4-b838-fc0a54ed296b

📥 Commits

Reviewing files that changed from the base of the PR and between 18872f7 and 72aac0b.

📒 Files selected for processing (1)

tests/site-map.test.ts

🚧 Files skipped from review as they are similar to previous changes (1)

tests/site-map.test.ts

📝 Walkthrough

Walkthrough

The PR updates sitemap redirect test wording and adds a dated branch review ledger entry documenting historical commit replay, conflict resolutions, applied fixes, and validation results.

Changes

Sitemap review record

Layer / File(s)	Summary
Sitemap redirect test wording `tests/site-map.test.ts`	The redirect-separation test description now states that public redirect handlers are excluded from API routes while their redirects are recorded.
Branch review ledger entry `docs/branch-review-ledger.md`	A `2026-07-18` entry records the historical commit replay, preserved conflict resolutions, applied sitemap and UI fixes, and check outcomes.

Estimated code review effort: 1 (Trivial) | ~3 minutes

Possibly related PRs

BigSimmo/Database#739: Updates sitemap documentation and tests involving redirect data and route handling.
BigSimmo/Database#810: Adds a related 2026-07-18 branch review ledger entry.
BigSimmo/Database#832: Changes sitemap redirect generation and related test coverage.

Suggested labels: codex

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly matches the main change: safely replaying design-audit remediations onto fresh main.
Description check	✅ Passed	The PR description covers summary, verification, and risk/rollback, matching the required template closely.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Create stacked PR
Commit on current branch

🧪 Generate unit tests (beta)

Create PR with unit tests
Commit unit tests in branch codex/main-merge-51278-final-20260718-late

_{Comment @coderabbitai help to get the list of available commands.}

supabase · 2026-07-18T13:21:33Z

This pull request has been ignored for the connected project sjrfecxgysukkwxsowpy because there are no changes detected in supabase directory. You can change this behaviour in Project Integrations Settings ↗︎.

Preview Branches by Supabase.
Learn more about Supabase Branching ↗︎.

github-actions · 2026-07-18T13:23:35Z

CI triage

CI failed on this PR. Automated classification of the 6 failed job(s):

Build — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
Advisory UI — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
Static PR checks — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
Unit coverage — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
Production UI — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.
PR required — needs investigation: inspect the failing step and uploaded diagnostics; rerun only after classifying the cause.

Compared with main CI run #3291 (success).

Classification is evidence routing, not permission to ignore a failure. Exact quarantined Playwright identities remain governed by the flake ledger.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 1d8b0617ca

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

BigSimmo · 2026-07-18T13:24:00Z

@codex resolve actionable Codex review findings for this pull request and current head using the repository instructions. This is the pull request's single automatic repair pass: do not perform a fresh review, create new standalone findings, or request another review. Work only the existing unresolved Codex threads on the current head. Always fix P0 and P1 findings. For P2 and lower findings, fix only clear, scoped, low-risk issues; otherwise disposition them with a concise reason. After fixing or dispositioning a thread, reply in that thread with as the first line, followed by a concise summary; that marker authorizes the workflow to close that exact thread. If human input or new authorization is required, do not use the marker and leave the thread open with the blocker. Finish only after every actionable thread is fixed or dispositioned and closed, or explicitly left open for a human decision. Do not update the branch from main, address unrelated reviews, broaden scope, or create more than one scoped fix commit. Do not use external APIs, paid services, credentials, dependency changes, or broad refactors unless explicitly authorized. Add targeted tests where behavior changes and run the narrowest relevant validation.

Keep the forms Refine gating fix on top of the merged sitemap/ledger remediation so #858 can fast-forward merge cleanly. Co-authored-by: BigSimmo <BigSimmo@users.noreply.github.com>

BigSimmo added 3 commits July 18, 2026 21:14

chore: merge design-audit remediation changes

45fa3c6

(cherry picked from commit 51278a7)

fix: resolve design audit merge regressions

14a0a89

docs: record safe design audit merge review

1d8b061

chatgpt-codex-connector Bot reviewed Jul 18, 2026

View reviewed changes

Comment thread src/app/page.tsx

Comment thread tests/site-map.test.ts

BigSimmo added 2 commits July 18, 2026 21:26

fix: clear merge verification regressions

18872f7

fix: restore redirect query contracts

72aac0b

BigSimmo enabled auto-merge (squash) July 18, 2026 13:32

BigSimmo merged commit 2f5b22a into main Jul 18, 2026
20 checks passed

BigSimmo deleted the codex/main-merge-51278-final-20260718-late branch July 18, 2026 13:35

This was referenced Jul 18, 2026

chore: apply 51278a70d remediations onto origin/main #857

Closed

chore: align 51278 merge regression tests with current contracts #860

Closed

cursor Bot mentioned this pull request Jul 18, 2026

fix: gate demo-mode forms UI for ui test fixture compatibility #862

Closed

9 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: safely integrate design-audit remediations#859

fix: safely integrate design-audit remediations#859
BigSimmo merged 5 commits into
mainfrom
codex/main-merge-51278-final-20260718-late

BigSimmo commented Jul 18, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Jul 18, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

supabase Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

BigSimmo commented Jul 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

BigSimmo commented Jul 18, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary

Verification

Risk and rollout

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

supabase Bot commented Jul 18, 2026

Uh oh!

github-actions Bot commented Jul 18, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

CI triage

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

BigSimmo commented Jul 18, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

BigSimmo commented Jul 18, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Jul 18, 2026 •

edited

Loading

github-actions Bot commented Jul 18, 2026 •

edited

Loading